CNI should invoke ipam release call even if delete endpoint fails #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failed, CNI should invoke ipam release call.
sharmasushant
suggested changes
Oct 18, 2017
cni/network/network.go
Outdated
| if err != nil { | ||
| err = plugin.Errorf("Failed to release address: %v", err) | ||
| return err | ||
| log.Printf("Failed to release address: %v", err) |
Contributor
There was a problem hiding this comment.
Let it throw here. Handle it in IPAM. ReleaseAddress should not fail in IPAM.
sharmasushant
suggested changes
Oct 18, 2017
| } | ||
|
|
||
| // Delete the endpoint. | ||
| err = plugin.nm.DeleteEndpoint(networkId, endpointId) |
Contributor
There was a problem hiding this comment.
Update DeleteLink in netlink implementation. Throw the error here!
sharmasushant
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes sure that there is no ip address leak even if delete endpoint(removing veth pair and resources) fails. It assumes container namespace would have been removed already and will invoke ipam release call to release ip address and other resources