[NPM] Supporting Namespace label updates #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 41.79% 41.88% +0.09%
==========================================
Files 142 142
Lines 13763 13843 +80
==========================================
+ Hits 5752 5798 +46
- Misses 7293 7322 +29
- Partials 718 723 +5 |
csfmomo
reviewed
Jan 29, 2021
|
|
||
| npMgr.Lock() | ||
| if err := npMgr.AddNamespace(oldNsObj); err != nil { | ||
| t.Errorf("TestAddNamespaceLabel failed @ npMgr.AddNamespace") |
Contributor
There was a problem hiding this comment.
PR looks good to me. For these tests, is there anyway that we check the new namespace label has been added or delete besides no error happens?
csfmomo
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM currently deletes all the ipsets when an existing namespace is updated. This fix selectively deletes or adds only the changed labels for an existing Namespace.