chore: consolidating logger package for cns aks swift scenario code #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 42.07% 41.95% -0.13%
==========================================
Files 143 143
Lines 13884 13884
==========================================
- Hits 5842 5825 -17
- Misses 7334 7356 +22
+ Partials 708 703 -5 |
pjohnst5
changed the title
pjohnst5
changed the title
csfmomo
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making logger package consistent for cns aks swift scenario logging.
The command line flag was being honored, I just didnt' realize there were leftover logs on disk from previous containres
The pipeline shows a failure with goldpinger tests but I ran the same tests with the same CNS dirty version on an underlay in our runners sub and they passed so pretty sure the pipeline one is a flake
CONFIRMED : it was a flake, this same exact build passed the tests
https://msazure.visualstudio.com/One/_build/results?buildId=39844247&view=logs&j=c4e47b90-07e0-53db-2983-8e94a4f7f491&t=c4e47b90-07e0-53db-2983-8e94a4f7f491