Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Mar 9, 2021

Reason for Change:

  • Start adding NPM debug API's and integrate client into ACN CLI. Actual objects TBD but starting initiative:
./acn npm get npmgr
{
        "NsMap": {
                "all-namespaces": {
                        "PodMap": {}
                },
                "ns-default": {
                        "PodMap": {}
                },
                "ns-kube-node-lease": {
                        "PodMap": {}
                },
                "ns-kube-public": {
                        "PodMap": {}
                },
                "ns-kube-system": {
                        "PodMap": {}
                },
                "ns-perf": {
                        "PodMap": {}
                },
                "ns-testa": {
                        "PodMap": {}
                },
                "ns-testb": {
                        "PodMap": {}
                }
        },
        "PodMap": {
                "13914f4a-19a0-43c4-b1b9-5c0ce53280e1": "10.240.5.188",
                "34bac546-a41f-4816-a524-6c99876b0138": "10.240.2.165",
                "399f16d3-fed7-4b8d-8eb6-3e2ba6e51e9b": "10.240.3.251",
                "5a22701c-2726-4d96-8122-cbba1c07d348": "10.240.5.41",
                "5ed5293d-24b3-4989-9928-b0b42a53e1a6": "10.240.2.49",
                "618b6b68-09e3-4e86-b6c8-2e39fe64b645": "10.240.5.64",
                "7ca112b5-173f-4793-bbbe-7194f775853f": "10.240.3.112",
                "89b17391-97ac-4dc2-93b2-83a4e00e1a27": "10.240.7.50",
                "bd87f2ff-f833-4dcb-a8c6-a00ea13c41ac": "10.240.1.37",
                "c3baee43-05db-4957-8771-ec062185af4b": "10.240.6.55",
                "c4554edb-ac9c-4ad6-9cdf-7973f0b39d7c": "10.240.1.12",
                "c91acd83-0f63-4820-9016-ae19f4a88581": "10.240.2.246",
                "d88baeb7-9a3a-42d9-b5db-4b026ece8546": "10.240.5.61",
                "e4a1f688-a6cd-4019-aa82-08ba0f34a879": "10.240.1.209"
        },
        "TelemetryEnabled": true
}
  • Add pprof listening (TODO: enable/disable this through config)
  • Add basic test to Prometheus HTTP endpoint

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #817 (dd7e2bf) into master (9a352f2) will decrease coverage by 0.13%.
The diff coverage is 65.15%.

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   42.65%   42.52%   -0.14%     
==========================================
  Files         144      152       +8     
  Lines       14199    14335     +136     
==========================================
+ Hits         6057     6096      +39     
- Misses       7432     7525      +93     
- Partials      710      714       +4     

n.router.Handle(api.NPMMgrPath, n.GetNpmMgr(npMgr)).Methods(http.MethodGet)

n.router.PathPrefix("/debug/").Handler(http.DefaultServeMux)
n.router.HandleFunc("/debug/pprof/", pprof.Index)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these to APIs

// SetExists checks whehter an ipset exists.
func (ipsMgr *IpsetManager) SetExists(setName, kind string) bool {
m := ipsMgr.setMap
m := ipsMgr.SetMap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep them private and have a func to access them

Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@vakalapa vakalapa merged commit d169929 into Azure:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants