-
Notifications
You must be signed in to change notification settings - Fork 260
Npm debug tools #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npm debug tools #817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 42.65% 42.52% -0.14%
==========================================
Files 144 152 +8
Lines 14199 14335 +136
==========================================
+ Hits 6057 6096 +39
- Misses 7432 7525 +93
- Partials 710 714 +4 |
| n.router.Handle(api.NPMMgrPath, n.GetNpmMgr(npMgr)).Methods(http.MethodGet) | ||
|
|
||
| n.router.PathPrefix("/debug/").Handler(http.DefaultServeMux) | ||
| n.router.HandleFunc("/debug/pprof/", pprof.Index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these to APIs
| // SetExists checks whehter an ipset exists. | ||
| func (ipsMgr *IpsetManager) SetExists(setName, kind string) bool { | ||
| m := ipsMgr.setMap | ||
| m := ipsMgr.SetMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep them private and have a func to access them
vakalapa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
Reason for Change:
Issue Fixed:
Requirements:
Notes: