CNS Debug API to expose PodIpIdByOrchrestratorContext #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 41.92% 41.60% -0.32%
==========================================
Files 152 157 +5
Lines 14373 14973 +600
==========================================
+ Hits 6026 6230 +204
- Misses 7616 7992 +376
- Partials 731 751 +20 |
kmurudi
force-pushed
the
CNS_debugApi_getPodContexts
branch
from
ce697fd to
452a5e5
Compare
This API exposes the Httpservice struct field to display map of OrchestratorContext->PodIpID (UUID) and includes debug command getPodContexts for CLI use-case.
kmurudi
force-pushed
the
CNS_debugApi_getPodContexts
branch
from
452a5e5 to
dbb4e12
Compare
csfmomo
reviewed
Mar 26, 2021
csfmomo
reviewed
Mar 26, 2021
csfmomo
reviewed
Mar 26, 2021
Contributor
|
Looks good to me, left 3 format comments. |
kmurudi
force-pushed
the
CNS_debugApi_getPodContexts
branch
from
2f72144 to
fafbcc5
Compare
csfmomo
previously approved these changes
Mar 26, 2021
Added GET endpoint instead for API Handler instead of POST. Added separate test function. Formatting on multiple files under /cns.
kmurudi
force-pushed
the
CNS_debugApi_getPodContexts
branch
from
fafbcc5 to
2d318a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: This API exposes one of the Httpservice struct field to
display map of OrchestratorContext->PodIpID (UUID) and
includes debug command getPodContexts for CLI use-case.