[CNS] Debug - Expose In-memory data from HTTPRestService #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmurudi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
+ Coverage 42.10% 42.13% +0.02%
==========================================
Files 158 158
Lines 15025 15089 +64
==========================================
+ Hits 6327 6358 +31
- Misses 7926 7954 +28
- Partials 772 777 +5 |
kmurudi
force-pushed
the
CNS_Debug_HTTPRestService_Contexts
branch
7 times, most recently
from
8b8f623 to
6652dba
Compare
kmurudi
force-pushed
the
CNS_Debug_HTTPRestService_Contexts
branch
from
6652dba to
da5071c
Compare
ramiro-gamarra
previously approved these changes
Mar 26, 2021
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
I think this is fine to merge, but let's discuss the comments left first.
neaggarwMS
reviewed
Mar 26, 2021
| pm.mu.Lock() | ||
|
|
||
| return cns.IpamPoolMonitorStateSnapshot { | ||
| MinimumFreeIps: pm.MinimumFreeIps, |
Member
There was a problem hiding this comment.
Can you also return
cachedNNC nnc.NodeNetworkConfig
updatingIpsNotInUseCount int
Contributor
Author
There was a problem hiding this comment.
@neaggarwMS yes I have added them too to IPAMPoolMonitor in the latest commit, please review if that looks good and the CLI command/end-point we should name for this debug API.
kmurudi
force-pushed
the
CNS_Debug_HTTPRestService_Contexts
branch
from
c8bb282 to
3425da9
Compare
This commit has following changes - 1. Removed AllocatedIPCount field from HTTPRestService struct in restserver.go as it is not used in project. 2. Added debug command getInMemory and API to expose fields-HTTPRestService and 2 fields from IPAMPoolMonitor. Please review the naming of the command, handler and end point. 3. Added Test function to test the new api response. 4. Added changes as per review comments - Get request for Test endpoint.
kmurudi
force-pushed
the
CNS_Debug_HTTPRestService_Contexts
branch
from
3425da9 to
a53848e
Compare
cns/cnsclient/cnsclient_test.go
Outdated
| desiredIpAddress := "10.0.0.5" | ||
|
|
||
| secondaryIps := make([]string, 0) | ||
| secondaryIps = append(secondaryIps, desiredIpAddress) |
Contributor
There was a problem hiding this comment.
can just
secondaryIps := []string{desiredIpAddress}
ramiro-gamarra
previously approved these changes
Apr 7, 2021
In-memory data API - adding 2 more fields to IPAMPoolMonitor
kmurudi
force-pushed
the
CNS_Debug_HTTPRestService_Contexts
branch
from
a53848e to
9aa3781
Compare
ramiro-gamarra
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: [CNS] Debug API to expose In-Memory Data HTTPRestService
This commit has following changes -
Reason for Change: Helping in debug commands for CNS service.
Notes: Please review and suggest the naming of the command, handler and end point.