CNI changes to support baremetal scenario #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working into cni-baremetal-support
CNI changes to support baremetal scenario
ramiro-gamarra
previously approved these changes
Mar 25, 2021
| result := &cniTypesCurr.Result{} | ||
| var resultIpconfigs []*cniTypesCurr.IPConfig | ||
|
|
||
| if netRes.Interfaces != nil { |
Contributor
There was a problem hiding this comment.
nit: this check is not needed. looping on nil maps or slices is fine
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 41.99% 41.57% -0.43%
==========================================
Files 152 157 +5
Lines 14486 14920 +434
==========================================
+ Hits 6084 6203 +119
- Misses 7665 7971 +306
- Partials 737 746 +9 |
Formatting fix in printf
ramiro-gamarra
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support in CNI for "baremetal scenario" where when CNI is executed on baremetal nodes, it is pass through and invokes Azure's node service to configure container networking.