[CI] Add Cyclonus to merge validation #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
force-pushed
the
cyclonus
branch
8 times, most recently
from
dd53e3c to
8b8788d
Compare
matmerr
commented
Apr 28, 2021
matmerr
commented
Apr 28, 2021
JungukCho
reviewed
Apr 28, 2021
JungukCho
reviewed
Apr 28, 2021
test/cyclonus/install-cyclonus.yaml
Outdated
| name: cyclonus | ||
| imagePullPolicy: IfNotPresent | ||
| image: mfenwick100/cyclonus:v0.4.4 | ||
|
|
Contributor
There was a problem hiding this comment.
reason for newline here?
Contributor
There was a problem hiding this comment.
It seems it will be nice to have flexibility to control command later to have various testing environment.
JungukCho
reviewed
Apr 28, 2021
JungukCho
reviewed
Apr 28, 2021
| kubectl apply -f ./npm/azure-npm.yaml | ||
| - name: Run Cyclonus network policy test | ||
| run: make test-cyclonus |
Contributor
There was a problem hiding this comment.
NPM has dependency about telemetricHandle before running each controller. Does it have enough time to fail them to start each controller before running test-cyclonus when using kind cluster? If not, it may fail some of the first testsets. Can you check it in log files? We eventually remove these dependency later.
JungukCho
reviewed
Apr 29, 2021
matmerr
force-pushed
the
cyclonus
branch
4 times, most recently
from
638d6b4 to
0b68bac
Compare
vakalapa
reviewed
May 3, 2021
matmerr
force-pushed
the
cyclonus
branch
3 times, most recently
from
c5c353d to
f29ca15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: