[NPM] fix incorrect NsMap local cache management between nameSpaceController and PodController #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and podcontroller
vakalapa
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The shared NsMap local cache is incorrectly managed between nameSpaceController and PodController. So, if the podController first reconciles the event and adds the npm-namespace object into NsMap, nameSpaceController missed the chance to call AddToList function since the npm-namespace object exists in our NsMap cache.
In this PR, podController adds the npm-namespace object into NsMap only after successfully completing ipset operations for namespace of the pod if the npm-namespace object does not exist in NsMap cache.
Issue Fixed:
#865
Requirements:
Notes: