[NPM] Fix recent unit test failures from each controller #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to fix unit test failures in each controller. The root cause for the issues is that extra events are called even though controller's unit test does not call them. So, the result of unit tests are different from expected values. Since we activate all capabilities of sharedInformer, extra events are called based on sharedinformer's local cache.
Especially this issue comes up recently since a new extension for controller's unit tests by using fake exec seems to take longer than real exec. Thus, there is enough time for sharedInformer to call multiple events.
To make deterministic unit test for each controller, unit tests almost only leverage sharedInformer's local cache.
Issue Fixed:
Requirements:
Notes: