Skip to content

Conversation

@JungukCho
Copy link
Contributor

Reason for Change:

This PR is to fix unit test failures in each controller. The root cause for the issues is that extra events are called even though controller's unit test does not call them. So, the result of unit tests are different from expected values. Since we activate all capabilities of sharedInformer, extra events are called based on sharedinformer's local cache.
Especially this issue comes up recently since a new extension for controller's unit tests by using fake exec seems to take longer than real exec. Thus, there is enough time for sharedInformer to call multiple events.
To make deterministic unit test for each controller, unit tests almost only leverage sharedInformer's local cache.

Issue Fixed:

Requirements:

Notes:

@JungukCho JungukCho added bug npm Related to NPM. labels May 26, 2021
@JungukCho JungukCho merged commit 92165d8 into Azure:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants