Drop arp request for snatbridge apipa range #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added drop rule for arp request for snat bridge ip
| log.Printf("Drop ARP for snat bridge ip: %s", snatBridgeIP) | ||
| if err := dropArpForSnatBridgeIP(snatBridgeIP, azureSnatVeth0); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
are these calls idempotent? previously we were just returning if snatbridge exsited? #Resolved
Member
Author
There was a problem hiding this comment.
@chandanAggarwal yes these calls are idempotent...for ebtable we check if rule exists and add it..the other one where we set mac to bridge is idempotent..i tested this in runner setup which creates multuple swift pods and each pod invoke this codepath
tamilmani1989
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added drop rule for arp request for snat bridge ip
Reason for Change:
Issue Fixed:
Requirements:
Notes: