[NPM] Remove unused codes to save and restore ipset and iptables #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
approved these changes
Aug 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
There are a bug in Save and Restore functions in iptm.go. It does not store iptables information into file with the error message "exec: Stdout already set"
As the similar issue exists in Restore function in iptm.go.
The first commit fixed the issues (in save and restore of iptables) in this PR.
However, we all agree to delete those codes since it is not necessary to save iptables information now and saving iptables information has high overhead.
So, I clean-up related save and restore codes for iptables and ipset in following commits.
.Issue Fixed:
Requirements:
Notes: