Skip to content

fix: Improve boot time query on Windows #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2021
Merged

fix: Improve boot time query on Windows #966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ce4fc
Improve boot time query on Windows
Aug 9, 2021
d43ca0b
Ad tz info of time in log
zhiweiv Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 9 additions & 31 deletions platform/os_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ package platform
import (
"bytes"
"fmt"
"golang.org/x/sys/windows"
"os"
"os/exec"
"strings"
"syscall"
"time"

"github.com/Azure/azure-container-networking/log"
"golang.org/x/sys/windows"
)

const (
Expand Down Expand Up @@ -72,40 +72,18 @@ func GetProcessSupport() error {
return err
}

var tickCount = syscall.NewLazyDLL("kernel32.dll").NewProc("GetTickCount64")

// GetLastRebootTime returns the last time the system rebooted.
func GetLastRebootTime() (time.Time, error) {
out, err := exec.Command("cmd", "/c", "wmic os get lastbootuptime").Output()
if err != nil {
log.Printf("Failed to query wmic os get lastbootuptime, err: %v", err)
return time.Time{}.UTC(), err
}

lastBootupTime := strings.Split(strings.TrimSpace(string(out)), "\n")
if strings.TrimSpace(lastBootupTime[0]) != "LastBootUpTime" || len(lastBootupTime) != 2 {
log.Printf("Failed to retrieve boot time")
return time.Time{}.UTC(), fmt.Errorf("Failed to retrieve boot time with 'wmic os get lastbootuptime'")
}
systemBootupTime := strings.Split(lastBootupTime[1], ".")[0]

// The systembootuptime is in the format YYYYMMDDHHMMSS
bootYear := systemBootupTime[0:4]
bootMonth := systemBootupTime[4:6]
bootDay := systemBootupTime[6:8]
bootHour := systemBootupTime[8:10]
bootMin := systemBootupTime[10:12]
bootSec := systemBootupTime[12:14]
systemBootTime := bootYear + "-" + bootMonth + "-" + bootDay + " " + bootHour + ":" + bootMin + ":" + bootSec

log.Printf("Formatted Boot time: %s", systemBootTime)

// Parse the boot time.
layout := "2006-01-02 15:04:05"
rebootTime, err := time.ParseInLocation(layout, systemBootTime, time.Local)
Copy link
Contributor

@jsturtevant jsturtevant Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause a difference in output in different regions?

Copy link
Member

@tamilmani1989 tamilmani1989 Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on timezone, its printing the reboot time.

pst:

2021/08/09 13:19:34 [12816] Formatted Boot time: 2021-07-20 15:02:32

i then set it to ist:

2021/08/10 01:49:58 [17720] Formatted Boot time: 2021-07-21 03:32:32

if err != nil {
log.Printf("Failed to parse boot time, err:%v", err)
currentTime := time.Now()
output, _, err := tickCount.Call()
if errno, ok := err.(syscall.Errno); !ok || errno != 0 {
log.Printf("Failed to call GetTickCount64, err: %v", err)
return time.Time{}.UTC(), err
}

rebootTime := currentTime.Add(-time.Duration(output) * time.Millisecond).Truncate(time.Second)
log.Printf("Formatted Boot time: %s", rebootTime.Format(time.RFC3339))
return rebootTime.UTC(), nil
}

Expand Down