fix: Removes requirement that infra must always exist for ADE/devcenter projects#3372
Conversation
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSIContainerDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
ellismg
left a comment
There was a problem hiding this comment.
I'm okay with this as a quick fix to unblock the ADE scenarios, but I don't love the shape of the fix long term. I'd have two preferences:
- We teach
ImportManagerthat when we are in ADE mode it is expected that there is no infrastructure, and just have it returnInfra{}, nilas you have done here - however we retain the error for cases where we expect that theinfrafolder to not exist and that to be okay. - We export a well known error like
ErrNoInfraand have us return that and then the caller decide "is it okay that I got ErrNoInfra" for the case I care about (it would look to see if it is in ADE mode or not and then make the correct decision).
Or we just figure out a way to remove the import manager in favor of moving this responsibility into the Aspire project itself (a large work item).
Feel free to land this as is and file an issue against me to try to clean this up.
Resolves #3365
When users are leveraging ADE and devcenter it is expected that a local
infrafolder will not exist.In the
importerpackage we are unable to take a dependency on platform configuration and the importer should not enforce infra provider constraints