Adding retry after 20 seconds when deploying to ACA (max 3)#3470
Conversation
…-waiting-for-resources-time
…-waiting-for-resources-time
wbreza
left a comment
There was a problem hiding this comment.
Looks good however I'd like to see the feedback addressed before merging.
…-waiting-for-resources-time
…-waiting-for-resources-time
…-waiting-for-resources-time
ellismg
left a comment
There was a problem hiding this comment.
LGTM - Might be nice to add a mock test that 404's the first time and 200 OK's the second or third so we know we don't break this.
…-waiting-for-resources-time
Added mocked test for retry :) |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #3440
Based on an update from ACA about a common error during deploying (container registry is not found - 404), this PR is adding 3 retries after 20 seconds as a mitigation for:
Looking through the deployment issue maybe this helps:
We use Azure DNS Zones to generate the ACR's DNS and according to their documentation there's an up to 60 seconds propagation delay time. If the endpoint ain't working just after creation but works soon after. Using a delay might fix your issues. Here's Doc on the subject:
https://techcommunity.microsoft.com/t5/azure-database-support-blog/add-wait-operation-to-arm-template-deployment/ba-p/2915342
https://learn.microsoft.com/en-us/azure/dns/dns-faq