AutoOrManualGeneration for parameters#3580
Merged
Merged
Conversation
…togen-input-config
…togen-input-config
vhvb1989
requested review from
ellismg,
hemarina,
wbreza and
weikanglim
as code owners
ellismg
reviewed
Mar 25, 2024
Member
ellismg
left a comment
ellismg
left a comment
There was a problem hiding this comment.
Really love the change to move away from the inputs object and towards a set of bicep parameters. It feels like the right direction.
I'm still trying to wrap my head around the UX for "do you want to override this" and if we want to ask the question during azd provision.
Part of me feels like we had a more powerful bicep, that had a generate string function, we'd do something like this:
param someParameter string = generate_random_string(<string-generation-configuration>)
If we could have done that, then these parameters would have default values and we never would have prompted for them, just like we don't prompt for any optional parameters. If you wanted to set a different value you could use main.parameters.json to do so. This would work for all types of values.
I guess I wonder why we ask the question for these parameters (which feel like optional parameters with default values) and not for optional parameters in the bicep template like:
param useManagedIdentity bool = trueI'm just slightly worried that the "I want to provide a non autogenerated value" here is going to be the 5% case and we'll end up having most folks just treat these questions as a speedbump on the initial azd provision.
Will a typical aspire application have a lot of these?
The GIF is super cool by the way, thank you for including it on the PR.
ellismg
approved these changes
Mar 26, 2024
Member
ellismg
left a comment
ellismg
left a comment
There was a problem hiding this comment.
One small nit, would like the name of the template function to be camelCased instead of snake_cased
Otherwise, looks great - the generated bicep looks way more idiomatic than before, so we must be on the right track. Great work here, @vhvb1989.
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: microsoft/aspire#3090
fix: #3570