Skip to content

Make .devcontainer language specific#471

Merged
jongio merged 11 commits intoAzure:mainfrom
savannahostrowski:main
Aug 23, 2022
Merged

Make .devcontainer language specific#471
jongio merged 11 commits intoAzure:mainfrom
savannahostrowski:main

Conversation

@savannahostrowski
Copy link
Copy Markdown

Closes #88

There was a comment on this issue about deleting the reference to common/.devcontainer from repo.yaml but I don't see that in the file. Let me know if I missed anything!

Comment thread templates/todo/projects/csharp-mongo/.devcontainer/Dockerfile Outdated
@jongio jongio marked this pull request as draft August 17, 2022 21:12
@jongio
Copy link
Copy Markdown
Member

jongio commented Aug 17, 2022

Marking as draft so we can do a manual test pass against all of these templates with the new devcontainer updates.

Copy link
Copy Markdown
Member

@vhvb1989 vhvb1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have CI/CD tests to validate the Dockerfile (can build OK) and devcontainer is valid

Comment thread templates/common/.devcontainer/Dockerfile/base/Dockerfile Outdated
@jongio
Copy link
Copy Markdown
Member

jongio commented Aug 23, 2022

It would be good to have CI/CD tests to validate the Dockerfile (can build OK) and devcontainer is valid

It is now possible #504

@jongio jongio marked this pull request as ready for review August 23, 2022 15:24
@azure-sdk
Copy link
Copy Markdown
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/471

View Changes | Compare Changes


Project: todo-csharp-mongo

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-mongo -b pr/471

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/471

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/471

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/471

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/471

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/471

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/471

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/471

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/471

View Changes | Compare Changes


@jongio jongio merged commit 7ad9b25 into Azure:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit devcontainer.json per template

4 participants