Support modeling existing aiProject in composition #4876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
JeffreyCA,
hemarina,
wbreza and
weikanglim
as code owners
weikanglim
reviewed
Mar 4, 2025
| {{- if .AiProject }} | ||
| resource aiProjectRG 'Microsoft.Resources/resourceGroups@2021-04-01' existing = { | ||
| scope: subscription() | ||
| name: split(aiProjectConnectionString, ';')[2] |
Contributor
There was a problem hiding this comment.
Is the project connection string a fixed ordering?
weikanglim
reviewed
Mar 4, 2025
Comment on lines
+17
to
+23
| {{- if .AiProject }} | ||
| {{- if .AiProject.ConnStringFromEnvVar }} | ||
| "{{bicepName .AiProject.Name}}ConnectionString": { | ||
| "value": "${{`{`}}{{.AiProject.ConnStringFromEnvVar}}{{`}`}}" | ||
| }, | ||
| {{- end }} | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Does this make sense at all as a preExecExpand parameter in scaffold.go as a dynamic parameter values?
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
weikanglim
reviewed
Mar 4, 2025
| {{- if .AiFoundryProject }} | ||
| output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiFoundryProjectConnectionString | ||
| {{- if .AiProject }} | ||
| output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString |
Contributor
There was a problem hiding this comment.
Suggested change
| output AZURE_AIPROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString | |
| output AZURE_AI_PROJECT_CONNECTION_STRING string = aiModelsDeploy.outputs.aiProjectConnectionString |
Maybe this looks maybe and closer to #4746
weikanglim
reviewed
Mar 4, 2025
Comment on lines
-34
to
+49
| name: '${abbrs.storageStorageAccounts}hub${resourceToken}' | ||
| name: '${abbrs.storageStorageAccounts}${resourceToken}' |
Contributor
There was a problem hiding this comment.
Maybe a bad merge, restore hub to avoid collisions if that makes sense to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.