Debug prompt fixes/improvements #6537
Merged
+131
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inuing ExtensionHost.Run() is an exception where we instead continue
JeffreyCA
requested review from
hemarina,
rajeshkamal5050,
tg-msft,
vhvb1989,
wbreza and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the debugger prompt experience by fixing exit behavior when users decline or cancel debug prompts via AZD_DEBUG and AZD_EXT_DEBUG environment variables, and adds a mutex lock to prevent concurrent prompt access in the gRPC prompt service.
Changes:
- Modified
AZD_DEBUGmiddleware to exit immediately when user declines or presses Ctrl+C instead of looping - Updated
AZD_EXT_DEBUGbehavior to continue normally when user declines or cancels, preventing extension process from exiting while azd continues - Added prompt lock mechanism to prevent concurrent prompt access in gRPC extension prompt service
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| cli/azd/cmd/middleware/debug.go | Removed infinite loop, added proper handling for user decline and Ctrl+C cancellation |
| cli/azd/pkg/azdext/debugger.go | Changed return type to error, added ErrDebuggerAborted sentinel error, improved error handling for cancellation |
| cli/azd/pkg/azdext/extension_host.go | Ignored WaitForDebugger return value to continue execution regardless of debug prompt response |
| cli/azd/internal/grpcserver/prompt_service.go | Added promptLock mechanism and acquirePromptLock calls to all prompt methods to prevent concurrent access |
vhvb1989
approved these changes
Jan 16, 2026
rajeshkamal5050
approved these changes
Jan 16, 2026
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6538
This PR improves the debugger prompt experience when the
AZD_DEBUGorAZD_EXT_DEBUGenv var is set.AZD_DEBUG- when user answers No or inputsCtrl+C, azd exits immediately instead of re-prompting in a loop.AZD_EXT_DEBUG- when the user runs core commands likeazd upand has extensions withlistencapability, answering the prompt or inputtingCtrl+Calways continues normally so we don't end up in a bad state where the extension process exits while azd continues on.AZD_EXT_DEBUG- when the user invokes custom extension commands likeazd ai agent init, extension authors can callazdext.WaitForDebuggerand handle when user declines prompt or cancels viaCtrl+C.This PR also fixes a concurrency bug that can cause prompts to freeze up, such as when running
AZD_EXT_DEBUG=true azd upwith multiple extensions installed withlistencapability. The fix involves serializing all interactive prompts inpromptServicewith a context-aware gate.