Skip to content

Updating extension project generator to use Microsoft.NET.Sdk.Functions 4.3.0 #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Updating extension project generator to use Microsoft.NET.Sdk.Functions 4.3.0 #2247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97b4140
Upgrading Microsoft.NET.Sdk.Functions to 4.3.0 for worker.extensions …
kshyju Jan 30, 2024
0b2a643
Bump Sdk version
kshyju Jan 31, 2024
05bc53a
Update release notes.
kshyju Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/Sdk/ExtensionsCsprojGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ internal string GetCsProjContent()
}
}

string netSdkVersion = _azureFunctionsVersion.StartsWith(Constants.AzureFunctionsVersion3, StringComparison.OrdinalIgnoreCase) ? "3.1.2" : "4.2.0";
string netSdkVersion = _azureFunctionsVersion.StartsWith(Constants.AzureFunctionsVersion3, StringComparison.OrdinalIgnoreCase) ? "3.1.2" : "4.3.0";

return $@"
<Project Sdk=""Microsoft.NET.Sdk"">
Expand Down
2 changes: 1 addition & 1 deletion sdk/Sdk/Sdk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<MinorProductVersion>17</MinorProductVersion>
<VersionSuffix>-preview3</VersionSuffix>
<VersionSuffix>-preview4</VersionSuffix>
<TargetFrameworks>netstandard2.0;net472</TargetFrameworks>
<PackageId>Microsoft.Azure.Functions.Worker.Sdk</PackageId>
<Description>This package provides development time support for the Azure Functions .NET Worker.</Description>
Expand Down
9 changes: 2 additions & 7 deletions sdk/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@
- My change description (#PR/#issue)
-->

### Microsoft.Azure.Functions.Worker.Sdk <version> (meta package)
### Microsoft.Azure.Functions.Worker.Sdk 1.17.0-preview4 (meta package)

- Updating `Microsoft.Azure.Functions.Worker.Sdk.Generators` to 1.2.0
- Dependency updates in Metadata Loader extension

### Microsoft.Azure.Functions.Worker.Sdk.Generators 1.2.0

- Updating private references
- Updating extension project generator to use `Microsoft.NET.Sdk.Functions` 4.3.0 (#2247)
2 changes: 1 addition & 1 deletion test/FunctionMetadataGeneratorTests/ExtensionsCsProjGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private static string ExpectedCsProjV4()

<ItemGroup>
<PackageReference Include=""Microsoft.NETCore.Targets"" Version=""3.0.0"" PrivateAssets=""all"" />
<PackageReference Include=""Microsoft.NET.Sdk.Functions"" Version=""4.2.0"" />
<PackageReference Include=""Microsoft.NET.Sdk.Functions"" Version=""4.3.0"" />
<PackageReference Include=""Microsoft.Azure.WebJobs.Extensions.Storage"" Version=""4.0.3"" />
<PackageReference Include=""Microsoft.Azure.WebJobs.Extensions.Http"" Version=""3.0.0"" />
<PackageReference Include=""Microsoft.Azure.WebJobs.Extensions"" Version=""2.0.0"" />
Expand Down