Adding instructions for sharing this repo #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@1st1 and @radu-matei - your input would also be appreciated! |
|
Marie, making this repo a git submodule or subtree would totally work for the python-worker project! |
pragnagopa
approved these changes
Apr 5, 2018
Member
|
@mhoeger - Please can you please open tracking bugs on Java, Python and Node language worker repos to consumer .proto from here? |
radu-matei
approved these changes
Apr 5, 2018
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Yep, adding a submodule would work.
LGTM
Contributor
Author
|
Note: we're going to use subtrees not submodules. Submodules are notoriously painful, and combining git subtrees with an addition to the parent repo's .gitignore gives us the same benefits as submodules without the associated pain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to share this code for the .proto template file across all language workers to keep from getting out of sync and to keep from having to add changes to each repo manually.
(See here: Azure/azure-functions-host#2296)
The current proposed solution is to share this repo using git. This PR describes the process. Alternatively, we could share this code using language-respective package managers. The git approach seemed like a simpler solution since we are just sharing the template file and not language-specific files.