Removing naming strategy when documenting enum values

[JoachimL]

See #170

The current implementation, which changes the casing of enum values, is confusing our API clients.

[ghost]

All CLA requirements met.

[joostvanhassel]

Hi @JoachimL, This should already be solved by #159 (which is currently unreleased)

[JoachimL]

No, I don't think it is. The current main branch still accepts a NamingStrategy parameter, which is hard-coded to Camel Case. Check out https://github.com/healthfitnessnordic/azure-functions-openapi-extension/commits/feature/enum-names which I mentioned in my issue - it is based on main (including #159), and has the problem I describe.

[joostvanhassel]

In EnumExtensionsTests.cs it's validated an enum value starting with a Capital letter will be returned as such (here). Please note de optional parameter here defaults to DefaultNamingStrategy (set here). This namingstrategy does not apply changes to the value. From the documentation: The default naming strategy. Property names and dictionary keys are unchanged.

[JoachimL]

I am aware of that. Problem is, the naming strategy is hard coded to be Camel Case further up type chain, so it doesn’t matter what the default is. If you have a look at the example I referenced, you will see how this looks in a real life scenario.

This is actually a very good example of when unit tests aren’t enough.

[joostvanhassel]

In the PR I mentioned, the call of the method does not contain a NamingStrategy: line chaned

I had the exact same problem. Using the code from the PR, I no longer have the problem. But please note it has not yet been released; verion 0.7.2-preview still has the issue.

[JoachimL]

I’ll test when I’m back at a computer. As I’ve said a couple of times, current main branch still has the issue.

[JoachimL]

Had a thought: could it be that the previous PR only fixes inbound enums (eg as part of a POST/PUT payload) while mine fixes enums as part of a return payload?

[joostvanhassel]

🤔 perhaps; will test in a minute

[joostvanhassel]

Using latest main I get the proper enums in both request models and response models (screenshot below).

For reference:

  public class TestModel
  {
    public DrinkSize DrinkSize { get; set; }
  }

  [JsonConverter(typeof(StringEnumConverter))]
  public enum DrinkSize
  {
    Small,
    Medium,
    Large
  }

[JoachimL]

You are absolutely right. It already works. Closing :-)