Skip to content

Fix OTel test env var reset logic #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andystaples merged 1 commit into from
Jun 20, 2024
Merged

Fix OTel test env var reset logic #1066

andystaples merged 1 commit into from
Jun 20, 2024

Conversation

@andystaples
Copy link
Contributor

@andystaples andystaples commented Jun 19, 2024

Issue describing the changes in this PR

resolves #1063

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@andystaples andystaples self-assigned this Jun 19, 2024
Francisco-Gamino
Francisco-Gamino approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andystaples andystaples merged commit af76566 into dev Jun 20, 2024
@andystaples andystaples deleted the andystaples/otel-test-fix branch June 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

Assignees

@andystaples andystaples

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix OTel test concurrency issue

3 participants

@andystaples @Francisco-Gamino