-
Notifications
You must be signed in to change notification settings - Fork 54
Updated language worker protobuf version to 1.5.6 #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b
| # include the following people in the PRs. | ||
| # Language owners should get notified of any new changes to the proto file. | ||
|
|
||
| src/proto/FunctionRpc.proto @vrdmr @gavin-aguiar @YunchuWang @surgupta-msft @satvu @ejizba @alrod @anatolib @kaibocai @shreyas-gopalakrishna @amamounelsayed @Francisco-Gamino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this file should be included with this code change. @ejizba , do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine - the process for updating protobuf pulls in all files for the repo. I assume you followed these steps, right Andy? https://github.com/Azure/azure-functions-language-worker-protobuf#pulling-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ejizba for confirming.
Francisco-Gamino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b (#825) Co-authored-by: Anthony Staples <t-anstaples@microsoft.com>
…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b (#825) (#835) Co-authored-by: Anthony Staples <t-anstaples@microsoft.com> Co-authored-by: andystaples <77818326+andystaples@users.noreply.github.com> Co-authored-by: Anthony Staples <t-anstaples@microsoft.com>
Issue describing the changes in this PR
resolves #824
Pull request checklist
release_notes.mdAdditional information
Additional PR information