Skip to content

Conversation

@andystaples
Copy link
Contributor

Issue describing the changes in this PR

resolves #824

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b
# include the following people in the PRs.
# Language owners should get notified of any new changes to the proto file.

src/proto/FunctionRpc.proto @vrdmr @gavin-aguiar @YunchuWang @surgupta-msft @satvu @ejizba @alrod @anatolib @kaibocai @shreyas-gopalakrishna @amamounelsayed @Francisco-Gamino
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this file should be included with this code change. @ejizba , do you know?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine - the process for updating protobuf pulls in all files for the repo. I assume you followed these steps, right Andy? https://github.com/Azure/azure-functions-language-worker-protobuf#pulling-updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ejizba for confirming.

@Francisco-Gamino Francisco-Gamino self-requested a review June 14, 2022 21:25
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco-Gamino Francisco-Gamino merged commit a1f37d4 into dev Jun 14, 2022
Francisco-Gamino pushed a commit that referenced this pull request Jul 1, 2022
…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b (#825)

Co-authored-by: Anthony Staples <t-anstaples@microsoft.com>
Francisco-Gamino added a commit that referenced this pull request Jul 1, 2022
…e-worker-protobuf. Tag: v1.5.6-protofile. Commit: 7465f806778d6aa1e6ef3e8cd4bc96559c6ec72b (#825) (#835)

Co-authored-by: Anthony Staples <t-anstaples@microsoft.com>

Co-authored-by: andystaples <77818326+andystaples@users.noreply.github.com>
Co-authored-by: Anthony Staples <t-anstaples@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update protobuf to latest

4 participants