Address pyspec feedback for new programming model#112
Merged
YunchuWang merged 2 commits intodevfrom Apr 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #112 +/- ##
==========================================
+ Coverage 84.65% 84.67% +0.01%
==========================================
Files 46 46
Lines 2717 2714 -3
Branches 363 363
==========================================
- Hits 2300 2298 -2
Misses 343 343
+ Partials 74 73 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
YunchuWang
changed the title
Changes involving: 1. FunctionApp __init__ auth_level -> http_auth_level 2. FunctionApp __init__ remove app_kwargs 3. FunctionApp __init__ change asgi_app/wsgi_app to kwargs 4. Remove data type from route 5. Change all trigger decorators to noun naming
YunchuWang
force-pushed
the
wangbill/pystein-feedback
branch
from
134636f to
8579b2c
Compare
vrdmr
approved these changes
Apr 18, 2022
| self._auth_level = AuthLevel[http_auth_level] \ | ||
| if isinstance(http_auth_level, str) else http_auth_level | ||
|
|
||
| wsgi_app = kwargs.get("wsgi_app", None) |
Member
There was a problem hiding this comment.
Nice - making it a hidden feature :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes involving: