Conversation
Codecov Report
@@ Coverage Diff @@
## dev #122 +/- ##
==========================================
+ Coverage 85.87% 86.04% +0.17%
==========================================
Files 49 50 +1
Lines 2867 2903 +36
Branches 389 391 +2
==========================================
+ Hits 2462 2498 +36
Misses 329 329
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| they are parsed by function host. | ||
|
|
||
| Ref: | ||
| https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-event-grid-trigger |
There was a problem hiding this comment.
We need to create aka.ms links for this. @shreyabatra4 can you help with this?
There was a problem hiding this comment.
created - aka.ms/eventgridtrigger
There was a problem hiding this comment.
updated as per recommendation.
| they are parsed by function host. | ||
|
|
||
| Ref: | ||
| https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-event-grid-trigger |
There was a problem hiding this comment.
We need to create aka.ms links for this. @shreyabatra4 can you help with this?
There was a problem hiding this comment.
created - aka.ms/eventgridtrigger
There was a problem hiding this comment.
updated as per recommendation.
|
|
||
| return wrap | ||
|
|
||
| def write_event_grid(self, |
There was a problem hiding this comment.
Did we finalize of this name? write_event_grid_message would be more appropriate here IMO. Thoughts? @YunchuWang @vrdmr @shreyabatra4
There was a problem hiding this comment.
as write_event_hub_message is what we are doing for event hub, write_event_grid_message may be more aligned
There was a problem hiding this comment.
updated as per recommendation.
|
|
||
| return wrap | ||
|
|
||
| def write_event_grid(self, |
There was a problem hiding this comment.
Did we finalize of this name? write_event_grid_message would be more appropriate here IMO. Thoughts? @YunchuWang @vrdmr @shreyabatra4
There was a problem hiding this comment.
updated as per recommendation.
| they are parsed by function host. | ||
|
|
||
| Ref: | ||
| https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-event-grid-trigger |
There was a problem hiding this comment.
Change to aka.ms link here too
There was a problem hiding this comment.
updated as per recommendation.
| they are parsed by function host. | ||
|
|
||
| Ref: | ||
| https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-event-grid-trigger |
There was a problem hiding this comment.
Change to aka.ms link here too
There was a problem hiding this comment.
updated as per recommendation.
5 participants
No description provided.