Skip to content

GH#107: Skip setting multi Set-Cookie headers for python 3.7#125

Merged
YunchuWang merged 3 commits intodevfrom
wangbill/skip-multi-cookie-py-3.7
May 6, 2022
Merged

GH#107: Skip setting multi Set-Cookie headers for python 3.7#125
YunchuWang merged 3 commits intodevfrom
wangbill/skip-multi-cookie-py-3.7

Conversation

@YunchuWang
Copy link
Copy Markdown
Member

Skipping setting multiple Set-Cookie headers as SimpleCookie which is a standard python lib api in python3.7 does not support samesite attribute and would cause cookie parsing error. (Ref: https://docs.python.org/3/library/http.cookies.html). A warning will be given to customers who uses python3.7 and tries to set multiple cookie headers.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2022

Codecov Report

Merging #125 (7548d66) into dev (6f10a44) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
+ Coverage   85.85%   85.87%   +0.01%     
==========================================
  Files          49       49              
  Lines        2863     2867       +4     
  Branches      388      389       +1     
==========================================
+ Hits         2458     2462       +4     
  Misses        329      329              
  Partials       76       76              
Flag Coverage Δ
unittests 85.83% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure/functions/http.py 53.94% <100.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f10a44...7548d66. Read the comment docs.

@YunchuWang YunchuWang changed the title Wangbill/skip multi cookie py 3.7 GH#107: Skip setting multi Set-Cookie headers for python 3.7 May 5, 2022
Comment thread azure/functions/http.py
@YunchuWang YunchuWang merged commit 8a59124 into dev May 6, 2022
@YunchuWang YunchuWang deleted the wangbill/skip-multi-cookie-py-3.7 branch May 6, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants