GH#107: Skip setting multi Set-Cookie headers for python 3.7#125
Merged
YunchuWang merged 3 commits intodevfrom May 6, 2022
Merged
GH#107: Skip setting multi Set-Cookie headers for python 3.7#125YunchuWang merged 3 commits intodevfrom
YunchuWang merged 3 commits intodevfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #125 +/- ##
==========================================
+ Coverage 85.85% 85.87% +0.01%
==========================================
Files 49 49
Lines 2863 2867 +4
Branches 388 389 +1
==========================================
+ Hits 2458 2462 +4
Misses 329 329
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gavin-aguiar
approved these changes
May 6, 2022
vrdmr
reviewed
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping setting multiple Set-Cookie headers as SimpleCookie which is a standard python lib api in python3.7 does not support samesite attribute and would cause cookie parsing error. (Ref: https://docs.python.org/3/library/http.cookies.html). A warning will be given to customers who uses python3.7 and tries to set multiple cookie headers.