Skip to content

fix: Handle comma-separated values in x-forwarded-port header #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucadelauw wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: Handle comma-separated values in x-forwarded-port header #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24a9d0f
Handle comma-separated values in x-forwarded-port header
lucadelauw Nov 5, 2025
f750d08
Merge branch 'dev' into fix/proxy-port-header
lucadelauw Nov 6, 2025
fa11d5f
Merge branch 'dev' into fix/proxy-port-header
hallvictoria Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion azure/functions/_http_wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ def to_environ(self, errors_buffer: StringIO) -> Dict[str, Any]:
def _get_port(self, parsed_url, lowercased_headers: Dict[str, str]) -> int:
port: int = 80
if lowercased_headers.get('x-forwarded-port'):
return int(lowercased_headers['x-forwarded-port'])
# Handle comma-separated port values (e.g., "443,8080,433")
forwarded_port = lowercased_headers['x-forwarded-port'].split(',')[0].strip()
return int(forwarded_port)
elif getattr(parsed_url, 'port', None):
return int(parsed_url.port)
elif parsed_url.scheme == 'https':
Expand Down
18 changes: 18 additions & 0 deletions tests/test_http_wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,24 @@ def test_request_protocol_by_header(self):
self.assertEqual(environ['SERVER_PORT'], str(8081))
self.assertEqual(environ['wsgi.url_scheme'], 'https')

def test_request_protocol_by_header_with_multiple_ports(self):
func_request = self._generate_func_request(headers={
"x-forwarded-port": "443,8080,433"
})
error_buffer = StringIO()
environ = WsgiRequest(func_request).to_environ(error_buffer)
self.assertEqual(environ['SERVER_PORT'], str(443))
self.assertEqual(environ['wsgi.url_scheme'], 'https')

def test_request_protocol_by_header_with_spaces(self):
func_request = self._generate_func_request(headers={
"x-forwarded-port": " 8443 , 8080 "
})
error_buffer = StringIO()
environ = WsgiRequest(func_request).to_environ(error_buffer)
self.assertEqual(environ['SERVER_PORT'], str(8443))
self.assertEqual(environ['wsgi.url_scheme'], 'https')

def test_request_protocol_by_scheme(self):
func_request = self._generate_func_request(url="http://a.b.com")
error_buffer = StringIO()
Expand Down