Fix grpc size limitation #703
Conversation
Hazhzeng
force-pushed
the
hazeng/fix-message-limit
branch
from
69bb9dc to
2a5075b
Compare
| loop = asyncio._get_running_loop() | ||
| disp = cls(loop, host, port, worker_id, request_id, | ||
| connect_timeout, max_msg_len) | ||
| connect_timeout) |
There was a problem hiding this comment.
As you are changing the "max_msg_len", in a subsequent PR, let's start adding type suggestions for the parameters. I'll add a new issue for it.
def __init__(self, loop, host, port, worker_id, request_id,
grpc_connect_timeout, grpc_max_msg_len: int = -1):
There was a problem hiding this comment.
Felt this bug in prod. Was tough to troubleshoot. How can we tell if our azure app has the latest hotfix bits?
There was a problem hiding this comment.
Hi @TroyWitthoeft, we finished rollout the hotfix last week. You can check if your function host version is upgraded to 2.0.13998 or 3.0.13978. These two versions should have this HotFix.
There was a problem hiding this comment.
Got it. We're all set now. We were able to Kudu/SSH into the box and examine the dispatcher.py to confirm if we had the latest bits. A delete and redeploy got us the latest bits. But, I am curious. We dug around in the portal and couldn't find the functions host version listed anywhere. Any tips? Is it on a particular part of the blade? Available over REST? Printed to logs on startup, etc? Appreciate it. And thanks for the fix! Got us out of bind.
Description
Fixes Issue https://github.com/Azure/azure-functions-python-worker/pull/632/files#diff-9a16b2f8bcbe955d554031aec6e96442R47
The
self._grpc_max_msg_lenis set toNonedue to passing None intodispatcher.__init__()methodPR information
Quality of Code and Contribution Guidelines