Move setup scripts into separate folders #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started seeing test failures like this on Linux
During the database setup it seems like the scripts are being ran out of order - so the "create view" script was being ran before the table it was over was actually created.
It isn't clear at all why this suddenly broke - but given that our setup is just globbing all the .sql files from the directory that isn't guaranteed to come back in a specific order so wasn't safe to begin with.
The simple fix for this is just to be more specific about the order we execute them in. As the comment in the setup mentions using something like a sqlproj would be even better from a consistency standpoint, but that's a bit more than is the worth the effort at this time.
(I also added a few debugging messages to help diagnose future problems)