Skip to content

Conversation

@Charles-Gagnon
Copy link
Contributor

Added initial set of events - focusing on a few key metrics :

  • Overall and feature-specific usage
  • Query performance
  • Errors*

*Note that for errors all we capture is the name of exception type (e.g. InvalidOperationException). No PII is gathered for any of the events.

List of the non-Error events added :

  • Creation of handlers (one is created once per binding)
  • Input conversions being performed (maps to number of invocations of the binding)
  • Output binding table info cache hit/miss
  • Output binding execution trace and timings - one event for each sub-query (case sensitivity, column definitions, primary keys)
  • Output binding upsert perf (including # of batches inserted)

Copy link
Contributor

@chlafreniere chlafreniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the test failure. Looks good otherwise; I appreciate your thoroughness.

@Charles-Gagnon Charles-Gagnon merged commit d856cab into main Jan 25, 2022
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/events branch January 25, 2022 19:31
PBBlox pushed a commit to PBBlox/azure-functions-sql-extension that referenced this pull request Apr 6, 2025
* Add initial telemetry events

* cleanup

* static import

* Few more + order

* Upsert -> UpsertStart

* Fix test + cleanup

* Log correct exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants