Skip to content

Capture SqlException Number #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Capture SqlException Number #225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9429663
First attempt SqlException Error Code
chlafreniere Mar 30, 2022
08d1b61
Merge remote-tracking branch 'origin/main' into chlafren/errorCode
chlafreniere Apr 12, 2022
e5d07e4
Capture SqlException.Number
chlafreniere Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Telemetry/Telemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
using Microsoft.ApplicationInsights;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.Extensions.Configuration;
using System.Globalization;
using Microsoft.Data.SqlClient;

namespace Microsoft.Azure.WebJobs.Extensions.Sql.Telemetry
{
Expand Down Expand Up @@ -120,6 +122,7 @@ public void TrackException(TelemetryErrorName errorName, Exception exception, ID
this._logger.LogInformation($"Sending exception event: {exception.Message}");
properties ??= new Dictionary<string, string>();
properties.Add(TelemetryPropertyName.ErrorName.ToString(), errorName.ToString());
properties.Add(TelemetryPropertyName.ErrorCode.ToString(), ExtractErrorCode(exception));
//continue task in existing parallel thread
this._trackEventTask = this._trackEventTask.ContinueWith(
x => this.TrackExceptionTask(exception, properties, measurements)
Expand Down Expand Up @@ -276,6 +279,18 @@ private Dictionary<string, string> GetEventProperties(IDictionary<string, string
return this._commonProperties;
}
}

/// <summary>
/// Extract error code from known exception types
/// </summary>
private static string ExtractErrorCode(Exception ex)
{
if (ex != null && ex is SqlException)
{
return (ex as SqlException).Number.ToString(CultureInfo.InvariantCulture);
}
return string.Empty;
}
}

/// <summary>
Expand Down Expand Up @@ -330,7 +345,8 @@ public enum TelemetryPropertyName
HasIdentityColumn,
QueryType,
ServerVersion,
Type
Type,
ErrorCode
}

/// <summary>
Expand Down