Add doc with links to all related repos #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
MaddyDev and
chlafreniere
as code owners
chlafreniere
approved these changes
May 27, 2022
docs/SqlBindingRelatedRepos.md
Outdated
| ## Docs | ||
| [Azure SQL bindings for Functions | Microsoft Docs ](https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-azure-sql?tabs=in-process%2Cextensionv3&pivots=programming-language-csharp) | ||
|
|
||
| ## SQL Binding VSCode Extension |
Contributor
There was a problem hiding this comment.
"Bindings" instead of "Binding"
docs/SqlBindingRelatedRepos.md
Outdated
| [Azure/azure-functions-python-library: Azure Functions Python SDK (github.com)](https://github.com/Azure/azure-functions-python-library) | ||
|
|
||
| ### Python Worker | ||
| Need to add end to end tests for Sql Bindings here. |
Charles-Gagnon
approved these changes
May 27, 2022
| @@ -0,0 +1,35 @@ | |||
| # Azure SQL Bindings for Azure Functions | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Would suggest adding a brief one or two sentence description of what this document is
docs/SqlBindingRelatedRepos.md
Outdated
| # Azure SQL Bindings for Azure Functions | ||
|
|
||
| ## Docs | ||
| [Azure SQL bindings for Functions | Microsoft Docs ](https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-azure-sql?tabs=in-process%2Cextensionv3&pivots=programming-language-csharp) |
Contributor
There was a problem hiding this comment.
Remove en-us
And do you need all the parameters? If you're just linking to the page I'd remove them
Contributor
Author
There was a problem hiding this comment.
Ah yes, I can use the aka.ms/sqlbindings link instead
|
|
||
| ## SQL Bindings VSCode Extension | ||
| [azuredatastudio/extensions/sql-bindings at main · microsoft/azuredatastudio (github.com)](https://github.com/microsoft/azuredatastudio/tree/main/extensions/sql-bindings) | ||
| [sqltoolsservice/src/Microsoft.SqlTools.ServiceLayer/AzureFunctions at main · microsoft/sqltoolsservice (github.com)](https://github.com/microsoft/sqltoolsservice/tree/main/src/Microsoft.SqlTools.ServiceLayer/AzureFunctions) |
Contributor
There was a problem hiding this comment.
Would be helpful to have a brief description of what each of these repos is for
docs/SqlBindingRelatedRepos.md
Outdated
| [sqltoolsservice/src/Microsoft.SqlTools.ServiceLayer/AzureFunctions at main · microsoft/sqltoolsservice (github.com)](https://github.com/microsoft/sqltoolsservice/tree/main/src/Microsoft.SqlTools.ServiceLayer/AzureFunctions) | ||
|
|
||
| ## Templates | ||
| Currently we have templates for C#, JS, TS, and Python. |
Contributor
There was a problem hiding this comment.
Probably not necessary to call out the types specifically - it'll be annoying to update later on. Just say something like Contains templates for the various types of bindings and supported languages, each under a Sql* folder
docs/SqlBindingRelatedRepos.md
Outdated
| [Azure/azure-functions-python-library: Azure Functions Python SDK (github.com)](https://github.com/Azure/azure-functions-python-library) | ||
|
|
||
| ### Python Worker | ||
| Need to add end to end tests for SQL Bindings here. |
Contributor
There was a problem hiding this comment.
Just End to end tests for SQL Bindings in the Python Worker should suffice
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* Add doc with links to all related repos * Update SqlBindingRelatedRepos.md * Update SqlBindingRelatedRepos.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.