Skip to content

Conversation

@JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Aug 23, 2022

@JatinSanghvi
Copy link
Contributor Author

@Charles-Gagnon, we can rename column names to say _az_func_AttemptCount, etc. to make conflicts extremely unlikely. This would be a breaking change (where worker table is already created with older schema) but hopefully that will be acceptable by the team dependent on it at this point.

Also, please let me know if you have a different take on how to replace string literals with constants.

There are columns in global state table too that can be converted to constants.

@JatinSanghvi
Copy link
Contributor Author

@Charles-Gagnon, if we are going to change the table schema, I would also like to change the table name from Worker_* to Leases_* as the table is specific to user function, not to a worker (considering a worker is a function app instance).

@JatinSanghvi JatinSanghvi merged commit 7833025 into triggerbindings Aug 25, 2022
@JatinSanghvi JatinSanghvi deleted the JatinSanghvi/worker-column-names branch August 25, 2022 17:59
@JatinSanghvi
Copy link
Contributor Author

@lucyzhang929, @Charles-Gagnon, I will issue another PR to rename the worker table to leases table. Cosmos DB extension uses similar name as default name for the collection that is used to maintain leases (link).

PBBlox pushed a commit to PBBlox/azure-functions-sql-extension that referenced this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace string literals with constants for worker table column names

4 participants