Run PR validation on release branches and rename nuget to *-lapreview.nupkg #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
Charles-Gagnon
changed the base branch from
triggerbindings
to
release/LogicApps
dzsquared
approved these changes
Sep 1, 2022
Contributor
Author
|
Merging in now to get release package out asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the packages generated from the LA preview branch will have numbers that are very similar to the "official" nuget.org packages which could be dangerous (if the numbers happened to line up) and confusing (hard to tell where a package came from). Changing it to -lapreview will help avoid these problems.
Doing directly to release branch since this isn't something we want in main ever - so leaving it out of the triggerbindings branch to keep things clean for eventual merging there.