Skip to content

Add retry when attempting to release leases #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Add retry when attempting to release leases #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
560e946
Add retry when attempting to release leases
AmeyaRele Sep 8, 2022
10b9059
Address comments
AmeyaRele Sep 9, 2022
4b4f1a7
Address more comments
AmeyaRele Sep 12, 2022
ad18efb
Change loop structure according to comment
AmeyaRele Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Telemetry/Telemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ public enum TelemetryMeasureName
GetPrimaryKeysDurationMs,
InsertGlobalStateTableRowDurationMs,
ReleaseLeasesDurationMs,
RetryAttemptNumber,
SetLastSyncVersionDurationMs,
TransactionDurationMs,
UpdateLastSyncVersionDurationMs,
Expand All @@ -408,6 +409,7 @@ public enum TelemetryErrorName
ProcessChanges,
PropsNotExistOnTable,
ReleaseLeases,
ReleaseLeasesNoRetriesLeft,
ReleaseLeasesRollback,
RenewLeases,
RenewLeasesLoop,
Expand Down
42 changes: 24 additions & 18 deletions src/TriggerBinding/SqlTableChangeMonitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal sealed class SqlTableChangeMonitor<T> : IDisposable
public const int MaxLeaseRenewalCount = 10;
public const int LeaseIntervalInSeconds = 60;
public const int LeaseRenewalIntervalInSeconds = 15;

public const int MaxRetryReleaseLeases = 3;
private readonly string _connectionString;
private readonly int _userTableId;
private readonly SqlObject _userTable;
Expand Down Expand Up @@ -491,8 +491,9 @@ private async Task ReleaseLeasesAsync(SqlConnection connection, CancellationToke
await this._rowsLock.WaitAsync(token);
this._logger.LogDebugWithThreadId("END WaitRowsLock - ReleaseLeases");
long newLastSyncVersion = this.RecomputeLastSyncVersion();
bool retrySucceeded = false;

try
for (int retryCount = 1; retryCount <= MaxRetryReleaseLeases && !retrySucceeded; retryCount++)
{
var transactionSw = Stopwatch.StartNew();
long releaseLeasesDurationMs = 0L, updateLastSyncVersionDurationMs = 0L;
Expand Down Expand Up @@ -528,14 +529,30 @@ private async Task ReleaseLeasesAsync(SqlConnection connection, CancellationToke
{
[TelemetryMeasureName.ReleaseLeasesDurationMs] = releaseLeasesDurationMs,
[TelemetryMeasureName.UpdateLastSyncVersionDurationMs] = updateLastSyncVersionDurationMs,
[TelemetryMeasureName.TransactionDurationMs] = transactionSw.ElapsedMilliseconds,
};

TelemetryInstance.TrackEvent(TelemetryEventName.ReleaseLeasesEnd, this._telemetryProps, measures);
retrySucceeded = true;
}
catch (Exception ex)
{
this._logger.LogError($"Failed to execute SQL commands to release leases for table '{this._userTable.FullName}' due to exception: {ex.GetType()}. Exception message: {ex.Message}");
TelemetryInstance.TrackException(TelemetryErrorName.ReleaseLeases, ex, this._telemetryProps);
if (retryCount < MaxRetryReleaseLeases)
{
this._logger.LogError($"Failed to execute SQL commands to release leases in attempt: {retryCount} for table '{this._userTable.FullName}' due to exception: {ex.GetType()}. Exception message: {ex.Message}");

var measures = new Dictionary<TelemetryMeasureName, double>
{
[TelemetryMeasureName.RetryAttemptNumber] = retryCount,
};

TelemetryInstance.TrackException(TelemetryErrorName.ReleaseLeases, ex, this._telemetryProps, measures);
}
else
{
this._logger.LogError($"Failed to release leases for table '{this._userTable.FullName}' after {MaxRetryReleaseLeases} attempts due to exception: {ex.GetType()}. Exception message: {ex.Message}");
TelemetryInstance.TrackException(TelemetryErrorName.ReleaseLeasesNoRetriesLeft, ex, this._telemetryProps);
}

try
{
Expand All @@ -549,20 +566,9 @@ private async Task ReleaseLeasesAsync(SqlConnection connection, CancellationToke
}
}
}
catch (Exception e)
{
// What should we do if releasing the leases fails? We could try to release them again or just wait,
// since eventually the lease time will expire. Then another thread will re-process the same changes
// though, so less than ideal. But for now that's the functionality.
this._logger.LogError($"Failed to release leases for table '{this._userTable.FullName}' due to exception: {e.GetType()}. Exception message: {e.Message}");
TelemetryInstance.TrackException(TelemetryErrorName.ReleaseLeases, e, this._telemetryProps);
}
finally
{
// Want to do this before releasing the lock in case the renew leases thread wakes up. It will see that
// the state is checking for changes and not renew the (just released) leases.
await this.ClearRowsAsync(false);
}
// Want to do this before releasing the lock in case the renew leases thread wakes up. It will see that
// the state is checking for changes and not renew the (just released) leases.
await this.ClearRowsAsync(false);
}

/// <summary>
Expand Down