Skip to content

Add comment for explaining token cancellation #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmeyaRele merged 1 commit into from
Oct 10, 2022
Merged

Add comment for explaining token cancellation #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/TriggerBinding/SqlTableChangeMonitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ public SqlTableChangeMonitor(

public void Dispose()
{
// When the CheckForChanges loop is finished, it will cancel the lease renewal loop.
this._cancellationTokenSourceCheckForChanges.Cancel();
}

Expand Down
1 change: 0 additions & 1 deletion src/TriggerBinding/SqlTriggerListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ public async Task StartAsync(CancellationToken cancellationToken)

this._logger.LogInformation($"Starting SQL trigger listener for table: '{this._userTable.FullName}', function ID: '{this._userFunctionId}'.");

// TODO: Check if passing the cancellation token would be beneficial.
this._changeMonitor = new SqlTableChangeMonitor<T>(
this._connectionString,
userTableId,
Expand Down