Fix polling size override using wrong configuration value #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
MaddyDev
reviewed
Oct 14, 2022
MaddyDev
reviewed
Oct 14, 2022
MaddyDev
approved these changes
Oct 14, 2022
lucyzhang929
approved these changes
Oct 14, 2022
test/Common/TestUtils.cs
Outdated
| /// Creates a DataReceievedEventHandler that will wait for the specified regex and then check that | ||
| /// the matched group matches the expected value. | ||
| /// </summary> | ||
| /// <param name="taskCompletionSource">The task completion source to signal when the value is receieved</param> |
Contributor
Author
There was a problem hiding this comment.
This is seriously one of my least favorite words - my fingers just always want to spell it recieved.
chlafreniere
approved these changes
Oct 14, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
Fix polling size override using wrong configuration value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in #376 (copypaste typo)
It wasn't caught by the test because the default values were changed but the tests hadn't been updated with the new values. I fixed them to use the default values defined in the trigger code directly so this doesn't happen again if those are changed in the future.
I also added another check to watch for the log message we send to indicate what the batchSize/pollingInterval values are as a secondary verification.