samples for out of proc sql bindings #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaddyDev
requested review from
Charles-Gagnon,
chlafreniere and
lucyzhang929
as code owners
MaddyDev
changed the title
Contributor
Charles-Gagnon
left a comment
Charles-Gagnon
left a comment
There was a problem hiding this comment.
Looks like the lock files aren't fully updated, make sure you run dotnet restore --force-evaluate from the root directory.
samples/samples-outofproc/OutputBindingSamples/AddProductParams.cs
Outdated
Show resolved
Hide resolved
lucyzhang929
reviewed
Nov 3, 2022
samples/samples-outofproc/InputBindingSamples/GetProductNamesView.cs
Outdated
Show resolved
Hide resolved
chlafreniere
reviewed
Nov 3, 2022
Charles-Gagnon
approved these changes
Nov 3, 2022
Contributor
|
Why was the mvc package removed? |
Contributor
Author
Didn't want to add another package dependency for the samples being exposed to users when we can avoid them. (Simplest way to implement them without additional stuff is the key) |
lucyzhang929
approved these changes
Nov 7, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* add out of proc intial steps * rename namespace * update csproj * add outofproc proj to sln * add new samples-outofproc * remove ci.yml and extensions-ci * update xml * samples-outofproc * undo package lock updates * clean up urls * update comments * fix indentation * don't hardcode version * add nuget version range syntax * remove samplesOutofProc project * address comments * address comments part2 * missed set CommandText on output attribute * remove unused param from xml * fix formatting * test changes * fix build errors * add dependencies to Directory.package * recreated using az func extension for dependencies * remove webjob references & add worker references. * add Microsoft.AspNetCore.Mvc.Core ref * add params func * add more samples * fix output bindings and version string * adding multiple items * use default deserialization * create input and output binding folders * update xml * remove empty lines * run package restore and comments * merge main * package restore after merging main * update Mvc.Core to 2.0.1 * remove java classes * Microsoft.AspNetCore.Mvc.Core to 2.2.0 * remove java changes * remove mvc core package dependency * remove sample, simple types supported outofproc * build error fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples for out of proc functions. I have replicated all applicable samples that are in samples-csharp.
Excluded the following two samples examples: 1. AddProductsAsyncCollector, 2. AddProductsCollector since .NET isolated projects run in a separate worker process, bindings can't take advantage of rich binding classes, such as ICollector, IAsyncCollector, and CloudBlockBlob. (as stated in https://learn.microsoft.com/en-us/azure/azure-functions/dotnet-isolated-process-guide#output-bindings)