Throw exception for scaling configuration invalid value #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeyaRele
requested review from
Charles-Gagnon,
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
lucyzhang929
reviewed
Nov 3, 2022
…hub.com/Azure/azure-functions-sql-extension into ameyarele/scaling-config-invalid-values
Charles-Gagnon
approved these changes
Nov 7, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* Throw exception for scaling configuration invalid value * Change Exception type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436
Changed the behavior of scaling configuration to be consistent with other configuration values.
Also added a condition to throw exception for non-positive integer values as this would not result in exception, and cause the function to scale out infinitely.