Upsert logging improvements #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
lucyzhang929
approved these changes
Nov 14, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* Upsert logging improvements * case sensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was investigating an issue and found a couple places we could improve debug logging :
I also wrapped the exception thrown if an error occurs upserting the rows to provide a bit more context - before it would just give the direct exception that occurred (usually some generic SqlClient error) which doesn't tell the user where the issue might have come from. At least with this it should make it clearer where it happened which can help track it down.