Skip to content

Remove pinned python library version in python sample #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Remove pinned python library version in python sample #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea2a6b0
remove pinned package ver
lucyzhang929 Feb 10, 2023
7336499
update pipeline and setup guide
lucyzhang929 Feb 10, 2023
63bec4d
add back install azure-functions step
lucyzhang929 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds/azure-pipelines/template-steps-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ steps:
- script: |
pip3 install -r requirements.txt
workingDirectory: $(Build.SourcesDirectory)/samples/samples-python
displayName: Install azure-functions-1.11.3b1
displayName: Install samples-python dependencies

- task: Maven@3
displayName: Build Java Samples
Expand Down
6 changes: 0 additions & 6 deletions docs/GeneralSetup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,6 @@ These steps can be done in the Terminal/CLI or with PowerShell.
}
```

Add a preview version of the Python functions library to `requirements.txt`.

```txt
azure-functions==1.11.3b1
```

Add a setting in `local.settings.json` to isolate the worker dependencies.

```json
Expand Down
2 changes: 1 addition & 1 deletion samples/samples-python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Do not include azure-functions-worker as it may conflict with the Azure Functions platform

azure-functions==1.11.3b1
azure-functions
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple other places we reference this - should remove those too right? And then do we have this in the Learn docs anywhere?

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked myself and we do - https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-azure-sql?tabs=in-process%2Cextensionv4&pivots=programming-language-python#update-packages

I have a PR open for making some other updates already so I can take care of removing that too. Sound good?

Copy link
Contributor Author

@lucyzhang929 lucyzhang929 Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks Charles!