fix(client): Correct verbosity of correlation warnings and fix the callback context map#1357
Merged
fix(client): Correct verbosity of correlation warnings and fix the callback context map#1357
Conversation
jamdavi
requested review from
abhipsaMisra,
azabbasi,
drwill-ms and
timtay-microsoft
as code owners
drwill-ms
reviewed
Sep 14, 2021
timtay-microsoft
approved these changes
Sep 14, 2021
Contributor
Author
|
/azp run |
drwill-ms
approved these changes
Sep 14, 2021
|
Azure Pipelines successfully started running 4 pipeline(s). |
drwill-ms
reviewed
Sep 14, 2021
| correlationCallbackContexts.put(messageId, message.getCorrelatingMessageCallbackContext()); | ||
| correlationCallbacks.get(messageId).onRequestQueued(message, packet, correlationCallbackContexts.get(messageId)); | ||
| correlationCallbacks.put(correlationId, message.getCorrelatingMessageCallback()); | ||
| if (message.getCorrelatingMessageCallbackContext() != null) |
Contributor
There was a problem hiding this comment.
Consider calling and caching the result, so you don't have to call it twice.
There was a problem hiding this comment.
I don't see the point of adding a check or correlationId to be != null . message.getCorrelationId(); can't return null.
Am-I missing something?
/**
* Getter for the correlationId property
* @return The property value
*/
public String getCorrelationId()
{
// Codes_SRS_MESSAGE_34_045: [The function shall return the message's correlation ID.]
if (correlationId == null)
{
return "";
}
return correlationId;
}
Contributor
Author
There was a problem hiding this comment.
Ah I see, yes, that method is changed on my end (as part of a larger refactor) to a Lombok Getter/Setter but it isn't guarded with @nonnull. Thanks for catching that as I wasn't in the master branch when I was looking at the code.
I've updated the branch I'm working on to keep this behavior.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #1349 and fixes the following problems