(feat): Make thread names identifiable. by azabbasi · Pull Request #1395 · Azure/azure-iot-sdk-java

azabbasi · 2021-10-15T17:09:55Z

Checklist

I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-java/blob/main/.github/CONTRIBUTING.md).
I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
I submitted this PR against the correct branch:
- This pull-request is submitted against the main branch.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

azabbasi · 2021-10-15T17:10:31Z

    private static class ReactorRunner implements Callable<Object>
    {
-        private final static String THREAD_NAME = "azure-iot-sdk-ReactorRunner";
+        private final static String THREAD_FIXED_NAME = "azure-iot-sdk-ReactorRunner-";


Please ignore the static field rename, it's for my own tracking purposes, will revert when the PR is ready for review.

timtay-microsoft · 2021-10-18T20:58:40Z

As a user, I think I would like to have some say in what these threads are named. Maybe allow for a pattern like:

<user supplied string>-<SDK specific context>-<connection-id>

like

"multiplexedClient1234-IothubReactorRunner-<connection id guid>"

And if users don't provide a prefix here, we can just name the thread

"IothubReactorRunner-<connection id guid>"

That way, users can distinguish threads not only per connection, but per client/user defined context as well

What do you think @azabbasi ?

azabbasi · 2021-10-18T22:47:23Z

As a user, I think I would like to have some say in what these threads are named. Maybe allow for a pattern like:

<user supplied string>-<SDK specific context>-<connection-id>

like

"multiplexedClient1234-IothubReactorRunner-<connection id guid>"

And if users don't provide a prefix here, we can just name the thread

"IothubReactorRunner-<connection id guid>"

That way, users can distinguish threads not only per connection, but per client/user defined context as well

What do you think @azabbasi ?

Interesting, so where do you envision getting that prefix input? when instantiating the client?

Fix dependency AMQPS connection Update AmqpsConnection.java Some more fixes are in. Update AmqpsConnection.java Make adjustments.

azabbasi · 2021-11-01T22:53:43Z

/azp run Java Prod

azure-pipelines · 2021-11-01T22:53:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azabbasi · 2021-11-02T00:41:12Z

/azp run Java Prod

azure-pipelines · 2021-11-02T00:41:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azabbasi · 2021-11-02T17:27:22Z

/azp run Java Prod

azure-pipelines · 2021-11-02T17:27:31Z

Azure Pipelines successfully started running 1 pipeline(s).

timtay-microsoft · 2021-11-02T22:10:28Z

Just a heads up for when you merge: it is "identifiable" not "identifyable"

azabbasi · 2021-11-03T20:52:02Z

/azp run Java Prod

azure-pipelines · 2021-11-03T20:52:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azabbasi · 2021-11-03T22:04:37Z

/azp run SDL

azure-pipelines · 2021-11-03T22:04:47Z

Azure Pipelines successfully started running 1 pipeline(s).

…dk/iot/service/transport/amqps/AmqpFileUploadNotificationReceive.java Co-authored-by: timtay-microsoft <timtay@microsoft.com>

…/iot/device/transport/IotHubTransportTest.java Co-authored-by: timtay-microsoft <timtay@microsoft.com>

…/iot/device/transport/IotHubTransport.java Co-authored-by: timtay-microsoft <timtay@microsoft.com>

…/iot/device/transport/amqps/AmqpsIotHubConnection.java Co-authored-by: timtay-microsoft <timtay@microsoft.com>

…amqp/AmqpsConnection.java Co-authored-by: timtay-microsoft <timtay@microsoft.com>

azabbasi · 2021-11-03T23:07:39Z

/azp run Java Prod, SDL

azure-pipelines · 2021-11-03T23:07:51Z

Azure Pipelines successfully started running 2 pipeline(s).

azabbasi · 2021-11-03T23:49:24Z

/azp run Java Prod Basic, horton-java-gate

azure-pipelines · 2021-11-03T23:49:39Z

Azure Pipelines successfully started running 2 pipeline(s).

azabbasi commented Oct 15, 2021

View reviewed changes

timtay-microsoft reviewed Oct 18, 2021

View reviewed changes

Comment thread ...evice-client/src/main/java/com/microsoft/azure/sdk/iot/device/fileupload/FileUploadTask.java Outdated

azabbasi force-pushed the azabbasi/identifyalbeThreads branch from 452a14b to 932b696 Compare November 1, 2021 22:46

New approach to thread naming.

932b696

Fix dependency AMQPS connection Update AmqpsConnection.java Some more fixes are in. Update AmqpsConnection.java Make adjustments.

Fix all test issues.

f8566cc

Fix service client thread naming

d8b5048

timtay-microsoft reviewed Nov 2, 2021

View reviewed changes

Comment thread ...e/iot-device-client/src/main/java/com/microsoft/azure/sdk/iot/device/DeviceClientConfig.java Outdated

timtay-microsoft reviewed Nov 2, 2021

View reviewed changes

Comment thread ...device-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/IotHubSendTask.java

timtay-microsoft reviewed Nov 2, 2021

View reviewed changes

Comment thread ...evice-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/IotHubTransport.java Outdated

timtay-microsoft reviewed Nov 2, 2021

View reviewed changes

Comment thread .../src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsIotHubConnection.java Outdated

timtay-microsoft reviewed Nov 2, 2021

View reviewed changes

Comment thread .../src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/AmqpsIotHubConnection.java Outdated

azabbasi changed the title ~~Azabbasi/identifyalbe threads~~ Make thread names identifiable. Nov 2, 2021

azabbasi marked this pull request as ready for review November 2, 2021 23:12

azabbasi requested review from abhipsaMisra, drwill-ms and jamdavi as code owners November 2, 2021 23:12

Merge branch 'main' into azabbasi/identifyalbeThreads

823b148

azabbasi changed the title ~~Make thread names identifiable.~~ (feat): Make thread names identifiable. Nov 2, 2021

Fix tests and avoid all nullrefs

40ce23d