fix(iot-dev): Remove unnecessary tracking of direct method request Ids#1468
Merged
timtay-microsoft merged 3 commits intomainfrom Feb 11, 2022
Merged
fix(iot-dev): Remove unnecessary tracking of direct method request Ids#1468timtay-microsoft merged 3 commits intomainfrom
timtay-microsoft merged 3 commits intomainfrom
Conversation
method response messages should always be sent. Tracking them like this only allowed issues like #1465 to happen if the state is lost somehow This state is already not tracked for methods in AMQP
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
brycewang-microsoft,
drwill-ms and
jamdavi
as code owners
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
drwill-ms
approved these changes
Feb 10, 2022
Contributor
|
Are you doing the same for v2? |
Member
Author
Yep. I'll pull this into v2 from main once it is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
method response messages should always be sent. Tracking them like this only allowed issues like #1465 to happen if the state is lost somehow
This state is already not tracked for methods in AMQP