Skip to content

fix issue that message properties are not sent out when using MQTT#39

Closed
erich-wang wants to merge 2 commits intoAzure:masterfrom
erich-wang:msgProperty
Closed

fix issue that message properties are not sent out when using MQTT#39
erich-wang wants to merge 2 commits intoAzure:masterfrom
erich-wang:msgProperty

Conversation

@erich-wang
Copy link
Copy Markdown
Member

@erich-wang erich-wang commented Feb 20, 2017

the Message's properties are sent out when using AMQP/HTTPS but MQTT

@msftclas
Copy link
Copy Markdown

msftclas commented Feb 20, 2017

Hi @erich-wang, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

prmathur-microsoft
prmathur-microsoft reviewed Feb 22, 2017
View reviewed changes
Comment thread ...ce-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/mqtt/MqttMessaging.java
}

MessageProperty[] messageProperties = message.getProperties();
String messagePublishTopic;
Copy link
Copy Markdown
Member

@prmathur-microsoft prmathur-microsoft Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your change. This looks good and is much needed. Can you please also add a test case around this in device\iot-device-client\src\test\java\tests\unit\com\microsoft\azure\sdk\iot\device\transport\mqtt\MqttMessagingTest.java ?

Copy link
Copy Markdown
Member Author

@erich-wang erich-wang Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case has been added, please review, thanks.

@prmathur-microsoft
Copy link
Copy Markdown
Member

prmathur-microsoft commented Feb 23, 2017

Added a new requirement, squashed all the commits and checked in @f9e2af997932722357fa15b8eba13e3bbc2e7d76 commit. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@prmathur-microsoft prmathur-microsoft prmathur-microsoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@prmathur-microsoft prmathur-microsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erich-wang @msftclas @prmathur-microsoft