feat(prov-serv): Add APIs for getAttestationMechanism for individual …#677
Merged
timtay-microsoft merged 3 commits intomasterfrom Aug 26, 2020
Merged
feat(prov-serv): Add APIs for getAttestationMechanism for individual …#677timtay-microsoft merged 3 commits intomasterfrom
timtay-microsoft merged 3 commits intomasterfrom
Conversation
timtay-microsoft
force-pushed
the
dps
branch
2 times, most recently
from
0a0eb47 to
1d3c25c
Compare
Member
Author
|
Closing this as we will re-do the entire provisioning service client later |
…and group enrollments These new APIs allow you to retrieve the symmetric keys for enrollments using symmetric key attestation
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
prmathur-microsoft and
vinagesh
as code owners
Member
Author
|
Re-opening this PR since C# SDK recently added these APIs, so the Java SDK should keep parity |
abhipsaMisra
approved these changes
Aug 26, 2020
bikamani
reviewed
Aug 26, 2020
| * @return the attestation mechanism of the given individual enrollment | ||
| * @throws ProvisioningServiceClientException if any exception is thrown while getting the attestation mechanism | ||
| */ | ||
| public AttestationMechanism getIndividualEnrollmentAttestationMechanism(String registrationId) throws ProvisioningServiceClientException |
Contributor
There was a problem hiding this comment.
Since these are new APIs, is there an action todo for any public documentation?
This was referenced Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and group enrollments
These new APIs allow you to retrieve the symmetric keys for enrollments using symmetric key attestation, for instance
This was a service API that the SDK never implemented, but that customers do need
Issue #674 for reference on the service APIs