feat(device): support batch messages for HTTPS

[azabbasi]

No description provided.

[azabbasi]

This constructor is internal to the iot.device package.

[timtay-microsoft]

So how does IoTHub accept these batch messages if one is malformed? Is it an all-or-nothing type API?

[timtay-microsoft]

If we plan on adding bulk message support to AMQP later, shouldn't we not allow users to call this API over AMQP? Since HTTP is the only protocol that actually currently supports bulk messages, I'd expect to see

if (this.protocol != HTTPS)
{
    throw new UnsupportedOperationException("Bulk messages are only supported over HTTPS");
}

[azabbasi]

If we plan on adding bulk message support to AMQP later, shouldn't we not allow users to call this API over AMQP? Since HTTP is the only protocol that actually currently supports bulk messages, I'd expect to see

if (this.protocol != HTTPS)
{
    throw new UnsupportedOperationException("Bulk messages are only supported over HTTPS");
}

We sure can, We use the same API in our C# SDK and I tried to stay consistent with that. we can chat offline about this.

[azabbasi]

So how does IoTHub accept these batch messages if one is malformed? Is it an all-or-nothing type API?

This is an all or nothing API for HTTPS, I will add an e2e test to catch that and have coverage for those cases.

[bikamani]

what do nested messages mean here?

[azabbasi]

I have moved it to batched messages. That makes the batch message a wrapper around the same object type of Message.

[timtay-microsoft]

Just the one comment left, but otherwise looks good!

[azabbasi]

/azp run Java Prod Basic, Java Prod, SDL, horton-java-gate

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[timtay-microsoft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).