fix(iot-dev): Fix issue where notfiy call was not wrapped by synchronization block#893
Merged
timtay-microsoft merged 2 commits intomasterfrom Aug 13, 2020
Merged
fix(iot-dev): Fix issue where notfiy call was not wrapped by synchronization block#893timtay-microsoft merged 2 commits intomasterfrom
timtay-microsoft merged 2 commits intomasterfrom
Conversation
…ization block All notify calls must be wrapped in synchronization blocks on the object that will be notified. Otherwise the notify call will throw an IllegalMonitorStateException and won't wake up the send thread as expected
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
prmathur-microsoft and
vinagesh
as code owners
abhipsaMisra
approved these changes
Aug 13, 2020
bikamani
approved these changes
Aug 13, 2020
Contributor
bikamani
left a comment
bikamani
left a comment
There was a problem hiding this comment.
👍 Wondering how this got missed!!
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This was referenced Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All notify calls must be wrapped in synchronization blocks on the object that will be notified. Otherwise the notify call will throw an IllegalMonitorStateException and won't wake up the send thread as expected.
This PR just adds that synchronization block so that when the message is requeued, it will wake up the send thread