Upgrade resilience4j version and remove resilience4j retry internals from azure-kusto-ingest#421
Merged
AsafMah merged 1 commit intoAzure:masterfrom Mar 30, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
ohadbitt
approved these changes
Mar 24, 2025
Collaborator
ohadbitt
left a comment
ohadbitt
left a comment
There was a problem hiding this comment.
thanks
please remove io.vavr version const
…from azure-kusto-ingest
Contributor
Author
|
Could you include this in your next release please? |
AsafMah
approved these changes
Mar 26, 2025
Contributor
|
Reverting this - it fails https://github.com/Azure/azure-kusto-java/actions/runs/14154431937/job/39651835675 |
Collaborator
reverted as it failed our pipelines |
Contributor
Author
|
Just noticed that resilience4j retry >= 2.0.0 is build with java17 as mentioned in the https://github.com/resilience4j/resilience4j/releases/tag/v2.0.0 . |
|
Hello all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We have been running a spring boot upgrade from 2.7 to 3.3.x and also upgrading the azure-kusto-java library to the latest available version. The issue is that we cannot use the latest resilience4j versions but we have to use the version 1.7.1(which was released 4 years ago) because of how it is utilized here.
Changed
Upgraded resilience4j version from 1.7.1 to 2.3.0(latest). This was done because in version:
2.0.0 - Spring boot 2.7 is being supported
2.0.1 - Spring boot 3 is being supported
2.2.0 - Micronaut 4 is being supported
You can check their releases for more (https://github.com/resilience4j/resilience4j/releases)
Fixed
Removed internals of resilience4j-retry library from ResourceManager.
Feel free to review this PR and mark any concern.